Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The path of the offending field is now printed for config validation errors #2778

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 27, 2024

Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #2778 will not alter performance

Comparing 2777-bug-configuration-validation-error-messages-for-incorrect-types-dont-indicate-which-field-is-the-offender (3c14117) with main (b425274)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (b425274) to head (3c14117).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2778   +/-   ##
=======================================
  Coverage   90.87%   90.88%           
=======================================
  Files          62       62           
  Lines        5160     5165    +5     
  Branches      666      667    +1     
=======================================
+ Hits         4689     4694    +5     
  Misses        330      330           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 27, 2024
@edgarrmondragon edgarrmondragon merged commit 8474a24 into main Nov 27, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2777-bug-configuration-validation-error-messages-for-incorrect-types-dont-indicate-which-field-is-the-offender branch November 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Configuration validation error messages for incorrect types don't indicate which field is the offender
1 participant