Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JSON schema union types are no longer conformed into boolean values #2723

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 16, 2024

Long due.


📚 Documentation preview 📚: https://meltano-sdk--2723.org.readthedocs.build/en/2723/

Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #2723 will not alter performance

Comparing 2553-bug-a-flaw-in-is_boolean_type-causes-_conform_primitive_property-to-coerce-non-boolean-fields-to-boolean (fbf60a1) with main (036d50b)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (48fc646) to head (fbf60a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2723   +/-   ##
=======================================
  Coverage   90.55%   90.56%           
=======================================
  Files          62       62           
  Lines        4997     5001    +4     
  Branches      637      638    +1     
=======================================
+ Hits         4525     4529    +4     
  Misses        328      328           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon self-assigned this Oct 16, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 16, 2024
@edgarrmondragon edgarrmondragon merged commit 925664b into main Oct 16, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2553-bug-a-flaw-in-is_boolean_type-causes-_conform_primitive_property-to-coerce-non-boolean-fields-to-boolean branch October 16, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: a flaw in is_boolean_type causes _conform_primitive_property to coerce non-boolean fields to boolean
1 participant