Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecated Faker class in stream maps #2670

Conversation

Copy link

codspeed-hq bot commented Sep 15, 2024

CodSpeed Performance Report

Merging #2670 will not alter performance

Comparing 2669-tech-debt-deprecate-faker-in-stream-maps-context-and-recommend-seed_instance (2efadd0) with main (be8b101)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (4641361) to head (2efadd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          58       58           
  Lines        4891     4891           
  Branches      963      963           
=======================================
  Hits         4396     4396           
  Misses        344      344           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

singer_sdk/mapper.py Outdated Show resolved Hide resolved
@edgarrmondragon edgarrmondragon merged commit 708c828 into main Sep 16, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2669-tech-debt-deprecate-faker-in-stream-maps-context-and-recommend-seed_instance branch September 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tech debt: Deprecate Faker in stream maps context and recommend seed_instance
1 participant