-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mappers): Stream map expressions now have access to the Faker
class, rather than just a faker instance
#2578
Conversation
…pper expressions (provided a faker config is found).
CodSpeed Performance ReportMerging #2578 will not alter performanceComparing Summary
|
Hi @Mac-lp3, thanks for the PR! I've read through your post in #2537 also the docs in and https://faker.readthedocs.io/en/master/fakerclass.html#upgrade-guide and I think this makes and is the easiest way to add support for reproducible masking. I think it's worth documenting the new object that'll be available in the stream map context. Wdyt? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
=======================================
Coverage 89.47% 89.47%
=======================================
Files 58 58
Lines 4798 4798
Branches 936 936
=======================================
Hits 4293 4293
Misses 352 352
Partials 153 153 ☔ View full report in Codecov by Sentry. |
…he faker library to re-seed
Hi again @edgarrmondragon, Docs are now updated. I added Hope this is up to standard, but just lmk if not 🤝 |
Faker
class, rather than just a faker instance
Superseded by #2598 |
I made a post in the discussions about my motivation for this.
Note the Faker lib provides two ways to accomplish this:
The meltano mapper config would then look something like this:
Faker.factory
.With this approach, the meltano mapper config would have looked something like this:
Option 2 is actually what the faker docs recommend.
Unfortunately, option 2 does not allow for multiple locales. Given that, I thought it best to go with option 1, rather than breaking other people's code.
📚 Documentation preview 📚: https://meltano-sdk--2578.org.readthedocs.build/en/2578/