Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taps): Allow SQL tap developers to auto-skip certain schemas from discovery #2482

Merged

Conversation

Copy link

codspeed-hq bot commented Jun 17, 2024

CodSpeed Performance Report

Merging #2482 will not alter performance

Comparing edgarrmondragon/feat/sql-hardcoded-skip-streams (9ffd29e) with main (da883d9)

Summary

✅ 7 untouched benchmarks

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (da883d9) to head (9ffd29e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2482   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          62       62           
  Lines        5184     5188    +4     
  Branches      668      670    +2     
=======================================
+ Hits         4730     4734    +4     
  Misses        321      321           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sql-hardcoded-skip-streams branch from 38f207e to 6a5e9b8 Compare June 17, 2024 15:42
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sql-hardcoded-skip-streams branch 2 times, most recently from 6d23cf6 to 29157a9 Compare July 9, 2024 04:00
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sql-hardcoded-skip-streams branch from 29157a9 to dfe065d Compare July 16, 2024 18:24
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sql-hardcoded-skip-streams branch from dfe065d to 1a10506 Compare August 9, 2024 21:37
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sql-hardcoded-skip-streams branch 2 times, most recently from 8b3528e to 1a1950c Compare December 3, 2024 15:48
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/sql-hardcoded-skip-streams branch from 1a1950c to 9ffd29e Compare December 3, 2024 15:50
@edgarrmondragon edgarrmondragon changed the title feat: Allow SQL tap developers to auto-skip certain stream names from discovery feat: Allow SQL tap developers to auto-skip certain schemas from discovery Dec 3, 2024
@edgarrmondragon edgarrmondragon changed the title feat: Allow SQL tap developers to auto-skip certain schemas from discovery feat(taps): Allow SQL tap developers to auto-skip certain schemas from discovery Dec 3, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Dec 3, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 3, 2024 16:02
@edgarrmondragon edgarrmondragon merged commit b989747 into main Dec 3, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/sql-hardcoded-skip-streams branch December 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant