refactor: Use a TypedDict to annotate state dictionaries
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
from
74cce32 to
ae0ec18
Compare
CodSpeed Performance ReportMerging #2419 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
==========================================
+ Coverage 89.50% 89.52% +0.01%
==========================================
Files 58 58
Lines 4804 4813 +9
Branches 943 944 +1
==========================================
+ Hits 4300 4309 +9
Misses 351 351
Partials 153 153 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
3 times, most recently
from
8f8e352 to
7dfcd37
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
2 times, most recently
from
847c9a5 to
0b45e5b
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
4 times, most recently
from
d44d7cc to
736742c
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
from
736742c to
802de3f
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
2 times, most recently
from
691620c to
dd31066
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/state-typed-dict
branch
from
dd31066 to
7799453
Compare
|
Very little to gain from this at this point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2419.org.readthedocs.build/en/2419/