Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Ruff preview rules #2080

Closed

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 1, 2023

Copy link

codspeed-hq bot commented Dec 1, 2023

CodSpeed Performance Report

Merging #2080 will not alter performance

Comparing edgarrmondragon/chore/enable-ruff-preview-rules (4b9a62e) with main (fe0ff85)

Summary

✅ 4 untouched benchmarks

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4e82c65) 87.70% compared to head (16f0d37) 87.70%.
Report is 1 commits behind head on main.

❗ Current head 16f0d37 differs from pull request most recent head 4b9a62e. Consider uploading reports for the commit 4b9a62e to get more accurate results

Files Patch % Lines
singer_sdk/authenticators.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2080   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files          60       60           
  Lines        4935     4935           
  Branches     1005     1005           
=======================================
  Hits         4328     4328           
  Misses        425      425           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/enable-ruff-preview-rules branch from 9053f6a to 93a0cc5 Compare December 1, 2023 03:16
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 1, 2023 20:59
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners December 1, 2023 20:59
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/enable-ruff-preview-rules branch 2 times, most recently from da7008d to 0bd288d Compare December 5, 2023 16:01
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/enable-ruff-preview-rules branch from 0bd288d to 16f0d37 Compare December 5, 2023 23:04
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/enable-ruff-preview-rules branch December 6, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant