Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): Drop Python 3.7 support in cookiecutter templates #2018

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

visch
Copy link
Contributor

@visch visch commented Oct 11, 2023

@visch visch requested a review from a team as a code owner October 11, 2023 20:57
@visch visch changed the title Drop python3.7 support in cookeicutters chore: Drop python3.7 support in cookeicutters Oct 11, 2023
@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Oct 11, 2023

@visch I'm not against, but why? Is it blocking something? 😅


I ask because I've been reluctant to backport #1837 from the v1 branch to main because 3.7 is still ~1/3 of downloads:

sdk-monthly-downloads

@edgarrmondragon edgarrmondragon changed the title chore: Drop python3.7 support in cookeicutters feat(templates): Drop Python 3.7 support in cookeicutter templates Oct 11, 2023
@edgarrmondragon edgarrmondragon changed the title feat(templates): Drop Python 3.7 support in cookeicutter templates feat(templates): Drop Python 3.7 support in cookiecutter templates Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2018 (1379809) into main (672e38d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          58       58           
  Lines        4885     4885           
  Branches      777      777           
=======================================
  Hits         4242     4242           
  Misses        456      456           
  Partials      187      187           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title feat(templates): Drop Python 3.7 support in cookiecutter templates fix(templates): Drop Python 3.7 support in cookiecutter templates Oct 11, 2023
@edgarrmondragon edgarrmondragon changed the title fix(templates): Drop Python 3.7 support in cookiecutter templates feat(templates): Drop Python 3.7 support in cookiecutter templates Oct 11, 2023
@visch
Copy link
Contributor Author

visch commented Oct 11, 2023

@visch I'm not against, but why? Is it blocking something? 😅

I ask because I've been reluctant to backport #1837 from the v1 branch to main because 3.7 is still ~1/3 of downloads:

sdk-monthly-downloads

Not a huge deal for me I just hit that a down stream dependency i wanted to use for my tap required python 3.8 or higher (latest version of fsspec atleast). Since I had to update the cookie cutter on my side I figured it'd help some others down the road!

@visch
Copy link
Contributor Author

visch commented Oct 11, 2023

@visch I'm not against, but why? Is it blocking something? 😅

I ask because I've been reluctant to backport #1837 from the v1 branch to main because 3.7 is still ~1/3 of downloads:

sdk-monthly-downloads

Just remembered one other thing, I didn't touch the main pyproject toml file exactly for the reason you mentioned :) so we don't break anyone here but anyone new has a later version of Python required

@edgarrmondragon
Copy link
Collaborator

I just hit that a down stream dependency i wanted to use for my tap required python 3.8 or higher (latest version of fsspec atleast)

Yeah, I've hit those too and Poetry doesn't have good hints about what to do in those cases because it tries to add the latest version by default. I've found that adding the dependency manually and pointing to a version right before 3.7 support was dropped, works fine.

For the case of fsspec that'd be 2023.3.0.

That said, it probably doesn't hurt to start expecting new packages built with the templates to require Python >= 3.8.

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Oct 12, 2023
Merged via the queue into meltano:main with commit f1f87ac Oct 12, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants