-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): Drop Python 3.7 support in cookiecutter templates #2018
feat(templates): Drop Python 3.7 support in cookiecutter templates #2018
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2018 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 58 58
Lines 4885 4885
Branches 777 777
=======================================
Hits 4242 4242
Misses 456 456
Partials 187 187 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml
Outdated
Show resolved
Hide resolved
Not a huge deal for me I just hit that a down stream dependency i wanted to use for my tap required python 3.8 or higher (latest version of fsspec atleast). Since I had to update the cookie cutter on my side I figured it'd help some others down the road! |
…ect.toml Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Just remembered one other thing, I didn't touch the main pyproject toml file exactly for the reason you mentioned :) so we don't break anyone here but anyone new has a later version of Python required |
Yeah, I've hit those too and Poetry doesn't have good hints about what to do in those cases because it tries to add the latest version by default. I've found that adding the dependency manually and pointing to a version right before 3.7 support was dropped, works fine. For the case of That said, it probably doesn't hurt to start expecting new packages built with the templates to require Python >= 3.8. |
📚 Documentation preview 📚: https://meltano-sdk--2018.org.readthedocs.build/en/2018/