fix: Warn instead of crashing when schema helpers cannot append null to types
#1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## main #1970 +/- ##
==========================================
+ Coverage 87.08% 87.16% +0.07%
==========================================
Files 59 59
Lines 5112 5120 +8
Branches 827 827
==========================================
+ Hits 4452 4463 +11
+ Misses 465 463 -2
+ Partials 195 194 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
changed the title
null to typesnull to types
…fields-in-json-schema-helpers-should-only-warn-not-crash-the-tap
…fields-in-json-schema-helpers-should-only-warn-not-crash-the-tap
…fields-in-json-schema-helpers-should-only-warn-not-crash-the-tap
kgpayne
approved these changes
Sep 22, 2023
edgarrmondragon
deleted the
1969-bug-trying-to-append-null-for-optional-fields-in-json-schema-helpers-should-only-warn-not-crash-the-tap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1969
📚 Documentation preview 📚: https://meltano-sdk--1970.org.readthedocs.build/en/1970/