Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid registering mappers for unselected streams #1944

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 7, 2023

Closes #1942


📚 Documentation preview 📚: https://meltano-sdk--1944.org.readthedocs.build/en/1944/

@edgarrmondragon
Copy link
Collaborator Author

Sunk too much time trying to fix the failing SQLite test. Leaving it for now...

@edgarrmondragon edgarrmondragon force-pushed the 1942-bug-tap-fails-if-stream-maps-config-contains-a-key-for-an-unselected-stream branch from 07ed5fc to ae66f45 Compare January 30, 2024 01:17
Copy link

codspeed-hq bot commented Jan 30, 2024

CodSpeed Performance Report

Merging #1944 will not alter performance

Comparing 1942-bug-tap-fails-if-stream-maps-config-contains-a-key-for-an-unselected-stream (78553d9) with main (068beae)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (068beae) 88.47% compared to head (78553d9) 88.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1944      +/-   ##
==========================================
- Coverage   88.47%   88.18%   -0.30%     
==========================================
  Files          54       54              
  Lines        4721     4721              
  Branches      919      919              
==========================================
- Hits         4177     4163      -14     
- Misses        383      399      +16     
+ Partials      161      159       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 1942-bug-tap-fails-if-stream-maps-config-contains-a-key-for-an-unselected-stream branch from ae66f45 to 78553d9 Compare February 9, 2024 20:21
@edgarrmondragon edgarrmondragon deleted the 1942-bug-tap-fails-if-stream-maps-config-contains-a-key-for-an-unselected-stream branch April 5, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Tap fails if stream maps config contains a key for an unselected stream
1 participant