-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle replication key not found in stream schema #1927
Merged
edgarrmondragon
merged 18 commits into
meltano:main
from
mjsqu:bugfix/improve_err_msg_replication_key_not_present
Aug 28, 2023
Merged
fix: Handle replication key not found in stream schema #1927
edgarrmondragon
merged 18 commits into
meltano:main
from
mjsqu:bugfix/improve_err_msg_replication_key_not_present
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
mjsqu
changed the title
Handle replication key not found in stream schema
bugfix: Handle replication key not found in stream schema
Aug 27, 2023
mjsqu
changed the title
bugfix: Handle replication key not found in stream schema
fix: Handle replication key not found in stream schema
Aug 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
+ Coverage 86.96% 86.97% +0.01%
==========================================
Files 59 59
Lines 5087 5091 +4
Branches 824 825 +1
==========================================
+ Hits 4424 4428 +4
Misses 466 466
Partials 197 197
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… intentionally raise and exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing @mjsqu! Just a small nit.
Co-authored-by: Edgar R. M. <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Edgar R. M. <[email protected]>
edgarrmondragon
approved these changes
Aug 28, 2023
Thanks @mjsqu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1332
Changes:
InvalidReplicationKeyException
tosinger_sdk.exceptions
streams.core
. Aget()
is used to obtain thereplication_key
fromself.schema
, if the key is not present in the schema, the variabletype_dict
would equalNone
. A check has been added, if the value of thetype_dict
isNone
then the new exception is raisedtests/core/test_streams.py
which checks that aSimpleTestStream
withreplication_key
overridden to"INVALID"
raises the correctInvalidReplicationKeyException
exception.