use lru_cache instead of custom cache

meltano · Sep 14, 2023 · 668832b · 668832b
1 parent 6bea818
commit 668832b
Showing 1 changed file with 15 additions and 19 deletions.
diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py
@@ -58,7 +58,6 @@ def __init__(
         """
         self._config: dict[str, t.Any] = config or {}
         self._sqlalchemy_url: str | None = sqlalchemy_url or None
-        self._table_cols_cache: dict[str, dict[str, sqlalchemy.Column]] = {}
         self._schema_cache: list = []
 
     @property
@@ -593,6 +592,7 @@ def schema_exists(self, schema_name: str) -> bool:
 
         return schema_name in self._schema_cache
 
+    @lru_cache()
     def get_table_columns(
         self,
         full_table_name: str,
@@ -607,24 +607,20 @@ def get_table_columns(
         Returns:
             An ordered list of column objects.
         """
-        if full_table_name not in self._table_cols_cache:
-            _, schema_name, table_name = self.parse_full_table_name(full_table_name)
-            inspector = sqlalchemy.inspect(self._engine)
-            columns = inspector.get_columns(table_name, schema_name)
-
-            self._table_cols_cache[full_table_name] = {
-                col_meta["name"]: sqlalchemy.Column(
-                    col_meta["name"],
-                    col_meta["type"],
-                    nullable=col_meta.get("nullable", False),
-                )
-                for col_meta in columns
-                if not column_names
-                or col_meta["name"].casefold()
-                in {col.casefold() for col in column_names}
-            }
-
-        return self._table_cols_cache[full_table_name]
+        _, schema_name, table_name = self.parse_full_table_name(full_table_name)
+        inspector = sqlalchemy.inspect(self._engine)
+        columns = inspector.get_columns(table_name, schema_name)
+
+        return {
+            col_meta["name"]: sqlalchemy.Column(
+                col_meta["name"],
+                col_meta["type"],
+                nullable=col_meta.get("nullable", False),
+            )
+            for col_meta in columns
+            if not column_names
+            or col_meta["name"].casefold() in {col.casefold() for col in column_names}
+        }
 
     def get_table(
         self,