Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: viewproptypes export from deprecated prop types #929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yadigarbz
Copy link

Platforms affected

iOS & Android Referencing RN Issue #33734

What does this PR do?

Fixes issue #928

What testing has been done on this change?

All occurrences of ViewPropType import is changed to react-native's new deprecated-react-native-prop-types repo
Nothing to test

Tested features checklist

@abehoffman
Copy link

Any idea when this might be merged?

@yadigarbz
Copy link
Author

Any idea when this might be merged?

Unfortunately no

@Akeuuh
Copy link

Akeuuh commented Jul 21, 2022

Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes.

Thanks for this PR anyway, I was struggling on this issue today and found this solution too.

@yadigarbz
Copy link
Author

Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes.

Thanks for this PR anyway, I was struggling on this issue today and found this solution too.

A patch might also be created from my change list if you like. It would be really nice if a maintainer could have looked at it @bd-arc

@Akeuuh
Copy link

Akeuuh commented Jul 22, 2022

Seems like it can take a lot of time hehe

image

@BossBele
Copy link

To solve the issue temporarily, I have forked this branch and merged it into the fork's master. You can install like:

NPM

npm i git+https://github.com/LarvenLLC/react-native-snap-carousel.git

YARN

yarn add git+https://github.com/LarvenLLC/react-native-snap-carousel.git

Until when the PR is merged.

@amerikan
Copy link

@Anthony-Buisson @bd-arc can you please merge this 🙏🏼

@galaxyreal
Copy link

This helped me to solve the issue.

@batazo
Copy link

batazo commented Mar 23, 2023

The react-native-new-snap-carousel available on npm
https://www.npmjs.com/package/react-native-new-snap-carousel
https://github.com/bzozoo/react-native-new-snap-carousel

@aleksandarbos
Copy link

praying to the champions of react-native-snap-carousel realm to merge this pr 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.