ppx: remove string_to_json usage on js side
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreypopp
approved these changes
Nov 15, 2024
|
Ah good point. St like 1d93950? |
|
Yes, looks good! |
anmonteiro
reviewed
Nov 16, 2024
CHANGES.md
Outdated
| @@ -19,6 +19,8 @@ | |||
| ([#30](https://github.com/melange-community/melange-json/pull/30)) | |||
| - PPX: add support for `int64` in the runtime | |||
| ([#33](https://github.com/melange-community/melange-json/pull/33)) | |||
| - PPX: qualify `string_to_json` usage on js side | |||
There was a problem hiding this comment.
in the end this isn't really what ended up happening 😬
anmonteiro
approved these changes
Nov 16, 2024
jchavarri
changed the title
string_to_json usage on js sidestring_to_json usage on js side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
The first commit adds a test that shows the error on JS side. The second commit fixes it.