Fix: 필요없는 JPQL 삭제

mejaiKR · Oct 7, 2024 · de0814c · de0814c
1 parent 5d88a85
commit de0814c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/src/main/java/mejai/mejaigg/matchstreak/service/StreakService.java b/src/main/java/mejai/mejaigg/matchstreak/service/StreakService.java
@@ -140,17 +140,17 @@ private void updateStreakData(SearchHistory history, YearMonth dateYM, String pu
 				matchStreakRepository.save(matchDateStreak);
 			} catch (Exception e) {
 				log.error("Http Error: " + e.getMessage());
-				searchHistoryRepository.updateLastSuccessDateByHistoryId(history.getId(), i);
+				history.setLastSuccessDay(i);
+				searchHistoryRepository.save(history);
 				return;
 			}
 		}
 
 		if (dateYM.equals(YearMonth.now())) { // 만약 이번달인 경우
-			searchHistoryRepository.updateLastSuccessDateByHistoryId(history.getId(), YearMonthToEpochUtil.getNowDay());
+			history.setLastSuccessDay(YearMonthToEpochUtil.getNowDay());
 		} else {
-			searchHistoryRepository.updateLastSuccessDateByHistoryId(history.getId(),
-				31);
-			searchHistoryRepository.updateIsDoneByHistoryId(history.getId(), true);
+			history.setLastSuccessDay(dateYM.lengthOfMonth());
+			history.setDone(true);
 		}
 		searchHistoryRepository.save(history);
 	}

diff --git a/src/main/java/mejai/mejaigg/searchhistory/domain/SearchHistory.java b/src/main/java/mejai/mejaigg/searchhistory/domain/SearchHistory.java
@@ -48,6 +48,7 @@ public class SearchHistory extends BaseEntity {
 
 	@Column(name = "last_success_day", nullable = false)
 	@ColumnDefault("0")
+	@Setter
 	private int lastSuccessDay; // 마지막으로 api 콜이 성공한 날짜.
 
 	@ManyToOne(fetch = FetchType.LAZY)

diff --git a/src/main/java/mejai/mejaigg/searchhistory/repository/SearchHistoryRepository.java b/src/main/java/mejai/mejaigg/searchhistory/repository/SearchHistoryRepository.java
@@ -4,23 +4,10 @@
 import java.util.Optional;
 
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.Modifying;
-import org.springframework.data.jpa.repository.Query;
 
-import jakarta.transaction.Transactional;
 import mejai.mejaigg.searchhistory.domain.SearchHistory;
 import mejai.mejaigg.summoner.domain.Summoner;
 
 public interface SearchHistoryRepository extends JpaRepository<SearchHistory, Long> {
 	Optional<SearchHistory> findBySummonerAndDate(Summoner summoner, YearMonth date);
-
-	@Transactional
-	@Modifying
-	@Query("UPDATE SearchHistory sh SET sh.done = :isDone WHERE sh.id = :historyId")
-	void updateIsDoneByHistoryId(Long historyId, boolean isDone);
-
-	@Transactional
-	@Modifying
-	@Query("UPDATE SearchHistory sh SET sh.lastSuccessDay = :lastSuccessDay WHERE sh.id = :historyId")
-	void updateLastSuccessDateByHistoryId(Long historyId, int lastSuccessDay);
 }