Skip to content

Conversation

@Strift
Copy link
Contributor

@Strift Strift commented May 27, 2025

Pull Request

Related issue

Fixes #613

What does this PR do?

  • Make image field detection logic recursive to find nested image fields
  • Move image detection logic at the hit level - to handle documents with different structures
  • Add relevant unit tests

Image fields are only scanned up to the 10th level of depth in the object to avoid impacting performance too much. We can likely set this higher, but I'm not sure it's needed. Your feedback is welcome @CaroFG

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift Strift added the enhancement New feature or request label May 27, 2025
@Strift Strift marked this pull request as draft May 27, 2025 08:23
@Strift Strift requested review from CaroFG and mdubus May 27, 2025 08:48
@Strift Strift marked this pull request as ready for review May 27, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix image display logic

1 participant