- 
                Notifications
    You must be signed in to change notification settings 
- Fork 128
Revert "Bump the gradle-dependencies group across 1 directory with 7 updates" #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Bump the gradle-dependencies group across 1 directory with 7 updates" #894
Conversation
…updates …" This reverts commit 4557bac.
| WalkthroughThe build.gradle file updates multiple dependency versions by downgrading libraries across runtime, testing, and tooling scopes, including Gson, OkHttp/Okio, Jackson, JUnit BOM/Jupiter, and Lombok. Changes
 Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
 Pre-merge checks and finishing touches✅ Passed checks (3 passed)
 ✨ Finishing touches🧪 Generate unit tests
 Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs. 
 Please see the documentation for more information. Example: reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| bors merge | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
build.gradle (3)
57-58: Rely on the JUnit BOM; drop the explicit version on junit-jupiter.Keeps versions in one place and reduces drift. 5.13.0 is available for both the BOM and artifacts. (repo1.maven.org)
- testImplementation(platform('org.junit:junit-bom:5.13.0')) - testImplementation('org.junit.jupiter:junit-jupiter:5.13.0') + testImplementation(platform('org.junit:junit-bom:5.13.0')) + testImplementation('org.junit.jupiter:junit-jupiter')
64-64: Downgrading jackson-databind: re-check security posture.2.19.0 is on Central, but stepping back from 2.20.0 may skip fixes. Jackson has a long CVE history around polymorphic deserialization; ensure we don’t enable Default Typing or deserialize untrusted input, or prefer staying on 2.20.0. (mvnrepository.com)
- Consider keeping 2.20.0 if no concrete incompatibility drove the revert.
- If 2.19.0 is required, add tests/guards for safe deserialization and document the decision.
Optional centralize version to avoid drift:
- testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.19.0' + testImplementation "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}"
67-67: Align compileOnly Jackson with the test one and consider a single version definition.To prevent accidental skew, prefer a shared version property or Version Catalog for jackson-databind across scopes. (mvnrepository.com)
- compileOnly group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.19.0' + compileOnly "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
- build.gradle(1 hunks)
🔇 Additional comments (4)
build.gradle (4)
51-51: Gson 2.13.1 exists on Central; revert looks safe.Version 2.13.1 is published on Maven Central, so this downgrade won’t break resolution. (repo1.maven.org)
62-63: Test deps downgrade looks fine.Okio 3.12.0 and OkHttp 4.12.0 are published and compatible for typical test usage. (mvnrepository.com)
70-73: Lombok 1.18.38 is published; annotation processor wiring looks correct.No issues spotted; confirm builds run with -parameters/annotation processing enabled in CI. (repo1.maven.org)
54-54: Don't switch to implementation — OkHttp types are part of the public API.The class exposes okhttp3 types (public constructor CustomOkHttpClient(Config, OkHttpClient)), so changing
api→implementationwould hide OkHttp from consumers and break them; either keepapior first remove/abstract OkHttp types from public signatures.Location: src/main/java/com/meilisearch/sdk/http/CustomOkHttpClient.java (lines 20–27, public constructor at line 24).
Likely an incorrect or invalid review comment.
| Build succeeded: | 
Reverts #892
Summary by CodeRabbit