Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get scaling context && align error #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xinghun92
Copy link

@xinghun92 xinghun92 commented Jul 9, 2018

  • From the api doc of ffmpeg, sws_getContext will return null if an error occurs, otherwise a pointer to an allocated context.

  • If the width is not divisible by the align, wrong data will be processed.

wangsijie added 2 commits July 9, 2018 23:09
Change-Id: Ifcfe2e5244211c4dce5f04bc0ca6cf250f1aac90
Change-Id: I55e1fdf06a95ce969388ffba1cb2378b50333508
@xinghun92 xinghun92 changed the title fix: get scaling context error fix: get scaling context && align error Jul 18, 2018
@YaLTeR
Copy link
Contributor

YaLTeR commented Aug 26, 2018

Same ptr::is_null() => !ptr::is_null() should be applied for the resampling part too:

@barzamin
Copy link
Collaborator

These is_null checks were fixed in dc6ace9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants