Repository navigation
ci(actions): split claude pr-review concurrency queues - #220
Conversation
Generated-by: engineer-agent
Claude review status
🛠️ Review did not finish Attempted head This round did not publish: MODEL_NO_OUTPUT in phase compile. Anything listed below is from the last round that did. Re-run the workflow or push a new commit to try again. |
|
No actionable review feedback was provided. The only comments are Claude review status updates, and they explicitly say no reply is needed. No changes or commits were made. |
Generated-by: engineer-agent
|
🔧 Pushed CI fixes. Agent log |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef2e85dfce
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # in an inconsistent state. | ||
| concurrency: | ||
| group: claude-pr-review-${{ github.event.pull_request.number || github.event.issue.number }} | ||
| group: claude-pr-review-${{ github.event.pull_request.number || github.event.issue.number }}-${{ github.event_name == 'pull_request' && 'code' || 'comment' }} |
There was a problem hiding this comment.
Keep both review triggers in one serialization group
When an issue_comment is created or edited while a pull_request review for the same PR is running, these suffixes place the jobs in different concurrency groups, allowing both invocations of claude-pr-review to run simultaneously. Since that action posts review output and resolves stale threads, one run can reconcile partially updated state from the other and leave duplicate or stale threads—the inconsistency the comment immediately above says per-PR serialization prevents. Preserve a shared per-PR mutex and coalesce/debounce comment events before they enter it instead of splitting the mutex.
Useful? React with 👍 / 👎.
|
@chatgpt-codex-connector[bot] ❓ The review asks to keep a shared per-PR concurrency group and debounce comment events, but the task explicitly requires matching mega-e2e#346 by splitting (I've paused on this task. Reply here with the answer and I'll continue where I left off.) |
Summary
Updates the pr-review concurrency group to suffix code and comment-triggered runs separately, preventing issue_comment edits from canceling queued reviews for new PR commits while keeping in-progress reviews uncancelled.