Skip to content

ci(actions): split claude pr-review concurrency queues - #220

Merged
Troublor merged 2 commits into
mainfrom
mega-engineer/ci/change-only-the-github-actions-concurren
Sep 17, 2026
Merged

Troublor merged 2 commits into
mainfrom
mega-engineer/ci/change-only-the-github-actions-concurren

Conversation

@mega-putin

@mega-putin mega-putin Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Generated by engineer-agent — review carefully before merging.

Summary

Updates the pr-review concurrency group to suffix code and comment-triggered runs separately, preventing issue_comment edits from canceling queued reviews for new PR commits while keeping in-progress reviews uncancelled.

Generated-by: engineer-agent
@mega-maxwell

mega-maxwell Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

🛠️ Review did not finish

Attempted head 3c26eaf8 · updated 2026-09-16T15:29:29+00:00

This round did not publish: MODEL_NO_OUTPUT in phase compile. Anything listed below is from the last round that did. Re-run the workflow or push a new commit to try again.

@mega-putin

mega-putin Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

No actionable review feedback was provided. The only comments are Claude review status updates, and they explicitly say no reply is needed. No changes or commits were made.

Generated-by: engineer-agent
@mega-putin

mega-putin Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

🔧 Pushed CI fixes.

Agent log
Verified the failing job at check-run/job level: `pr-review` failed with `MODEL_NO_OUTPUT` from the Claude review action, not a repository build/test/lint failure.

Actions taken:
- Re-validated `.github/workflows/claude.yml` parses as YAML.
- Created an empty commit to trigger a fresh CI/review run.

Commit:
- `3c26eaf fix CI: rerun claude pr review`

No push was performed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef2e85dfce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

# in an inconsistent state.
concurrency:
group: claude-pr-review-${{ github.event.pull_request.number || github.event.issue.number }}
group: claude-pr-review-${{ github.event.pull_request.number || github.event.issue.number }}-${{ github.event_name == 'pull_request' && 'code' || 'comment' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep both review triggers in one serialization group

When an issue_comment is created or edited while a pull_request review for the same PR is running, these suffixes place the jobs in different concurrency groups, allowing both invocations of claude-pr-review to run simultaneously. Since that action posts review output and resolves stale threads, one run can reconcile partially updated state from the other and leave duplicate or stale threads—the inconsistency the comment immediately above says per-PR serialization prevents. Preserve a shared per-PR mutex and coalesce/debounce comment events before they enter it instead of splitting the mutex.

Useful? React with 👍 / 👎.

@mega-putin

mega-putin Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

@chatgpt-codex-connector[bot] ❓ The review asks to keep a shared per-PR concurrency group and debounce comment events, but the task explicitly requires matching mega-e2e#346 by splitting pr-review into -code and -comment concurrency groups; should I follow the reviewer and abandon the requested split, or keep the requested one-line split?

(I've paused on this task. Reply here with the answer and I'll continue where I left off.)

@Troublor
Troublor merged commit b5b5711 into main Sep 17, 2026
20 of 21 checks passed
@mega-putin
mega-putin Bot deleted the mega-engineer/ci/change-only-the-github-actions-concurren branch September 17, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants