Repository navigation
fix: avoid persisting Git credentials in release actions - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release actions currently persist installation tokens in Git authentication headers. Add a command-scoped GitHub HTTPS authentication component using GIT_ASKPASS, disable credential storage for its commands, and use it for release fetches and pushes without changing Git auth configuration or remote URLs.
Keep existing release-action inputs compatible and add an optional read-only dependency_token for candidate dependency updates. Document the new action and exercise clone, recursive submodules, push, Cargo fetch followed by an offline build, authentication failures, stale checkout credentials, step outputs, and credential non-persistence against a local HTTPS Git server.
Test plan