Add mjrs_autoresume flag to audiobridge plugin (#3582) #3584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Apologies for the late feedback, and thanks for the PR! From a glance it looks ok, and the items I suggested in the issue seem all handled correctly. Looking forward to your testing in that regard! |
Member
|
@ettubrute47 any update on testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to allow automatically restart recording on resume from suspend without having to specify in the resume API call record: true if mjrs is enabled for the room. To avoid breaking change we add a flag mjrs_autoresume, default to false. See discussion in #3582 for further details.
I have tested compilation and acceptance of the flag in parsing the config, but have not tested the actual logic via suspend/resume yet. I will add to this when I do, but publishing this now for code visibility.