-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-flows,fulfillment, fulfillment-manual, types): make fulfillment typings more specific #10677
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
nit: I think we shouldn't be mixing types from different domains, e.g. the fulfillment service interface should not use the OrderDTO
, but instead a standalone type that happens to have properties shared with the other type.
@olivermrbl could you check the last commit |
What
CLOSES CMRC-814
CLOSES CMRC-816
CLOSES CMRC-817