Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#9690): monitor nouveau #9700

Merged
merged 4 commits into from
Dec 16, 2024
Merged

feat(#9690): monitor nouveau #9700

merged 4 commits into from
Dec 16, 2024

Conversation

m5r
Copy link
Contributor

@m5r m5r commented Dec 9, 2024

Description

#9690

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@m5r m5r force-pushed the 9690-nouveau-monitoring branch from a1bba0d to 657d6f8 Compare December 12, 2024 16:44
@m5r m5r marked this pull request as ready for review December 12, 2024 16:45
@m5r m5r requested a review from sugat009 December 12, 2024 16:46
@m5r
Copy link
Contributor Author

m5r commented Dec 12, 2024

@sugat009 the CI will stay red, it's failing because of the ECR issue tracked in #9685 but I ran the whole test suite locally and everything passed except a few unrelated wdio tests that I assume are flaky
Unless the ECR issue is fixed early enough, I would prefer to move forward and merge this into couchdb-nouveau to centralize everything under that branch

Copy link
Member

@sugat009 sugat009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@m5r m5r merged commit db53828 into couchdb-nouveau Dec 16, 2024
19 of 21 checks passed
@m5r m5r deleted the 9690-nouveau-monitoring branch December 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants