Create useFlip hook #183 #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leroykorterink
added
enhancement
ThaNarie
requested changes
Oct 23, 2023
| const [isFlipped, toggle] = useToggle(false); | ||
|
|
||
| const divRef = useRef<HTMLDivElement>(null); | ||
| useFlip(divRef, flipOptions); |
There was a problem hiding this comment.
flipOptions is not defined anywhere
| const flipStateRef = useRef<Flip.FlipState>(); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| if (globalThis.window !== undefined) { |
There was a problem hiding this comment.
It might be useful (for others, or future self), to add some comments explaining how/why this works.
I assume that:
- the
ifexecutes before potentially new style vars are set, capturing the "current" state. - the
useEffectexecutes after applying and rendering the new style vars, and then transitioning to them from the previously captured state.
|
|
||
| <Meta title="components/useFlip" of={stories} /> | ||
|
|
||
| # useFlip |
There was a problem hiding this comment.
It's unclear from the (non-existing) api docs:
- what I can pass as first parameter (can it be both an element, or also a ref around an element?)
- what I can pass as second parameter (some gsap flip props?)
- If the second param is optional or required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.