Create useClickedOutside hook #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leroykorterink
changed the title
ReneDrie
reviewed
May 16, 2023
|
|
||
| const onClick = useCallback( | ||
| (event: Event) => { | ||
| // Using element bounds because a click on a shadow element (e.g. dialog backdrop) is also |
There was a problem hiding this comment.
Using this way to check this would return "Inside" if you click on an element that could cover the entire element, so you're not really click the element? I don't think this is what you want.
There was a problem hiding this comment.
I guess you need to do both then.
- check if it's inside the expected bounds
- check if the clicked target is a child of the element
Could you (@leroykorterink) clarify why a backdrop would not influence the element bounding rect?
Also, both variations should have either a story or a test, currently the "backdrop" case doesn't have either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.