This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Continue refactoring libndt #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with us having already tests in the current directory that can be associated to files. My goal is to replicate the Go model where you have file.go and file_test.go containing tests for such file.
We know this because we're using sys_test.cpp to compile it and make sure everything is working as intended. This is in line with making libndt components less intertwined and making sure we can test them in isolation.
This was referenced Nov 14, 2019
robertodauria
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because libndt seems to be poised to become the default ndt5/ndt7 client offer for C++ users, I am going to do some more effort to ease its development, and to apply more best practices.
Namely, my objective is for a developer to be able to reason to individual libndt components in isolation, by inspecting the related sub-header and unit-tests.
In a previous refactoring commit, I tentatively started moving such sub-headers into a sub-directory, but now I realise this is partially confusing. It seems we already have tests into the top-level directory, hence I'd rather take the approach of having
foo.hppas subheader andfoo_test.cppas the related unit tests.I am not 100% satisfied with this approach as well, however, I'd say it's better to first finish splitting the library and have true unti tests. Then, we can provide more structure in a single commit that does not leave the tree in a state where the placement of files is inconsistent.
Thus, this PR mainly flattens the hierarchy. In addition to that, it also performs the necessary changes to make sure that the
sys.hppheader really works as a standalone header, because its related unit test file compiles successfully.Part of #144