Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show the current week instead of today + 7 days in meal planner #4907

Open
wants to merge 3 commits into
base: mealie-next
Choose a base branch
from

Conversation

simon-zumbrunnen
Copy link

What this PR does / why we need it:

The meal planner currently shows the next 7 days. With this pull request I propose to change this behaviour so the default is a weekly overview similar to how calendars usually work. The default setting for the time range is changed so it starts at the most recent "start of the week" according to the settings.

If this pull request is accepted I plan to implement buttons to get to the previous / next week.

Which issue(s) this PR fixes:

This does not directly fix any open issue but it is a step towards weekly shopping lists discussed in #1899.

Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept sounds like it would be a significant regression on my own UX. So if this is to become the default, I think you need to implement a lot of configurability.
It's uncommon to need to look at the history in the meal planner, and current functionality allows a user to set how many future days to include (I have it set to 12, FWIW).

@DenuxPlays
Copy link

Just a small Note:

Wouldnt it be possible to let the user define their own schedule?

So in my case I plan from thursday to thursday.

@Kuchenpirat
Copy link
Collaborator

The most flexible solution would probably to have a checkbox that can be enabled disabled that toggles a start day.
This should enable a dropdown menu where the user can choose the day the week should start with. This would offer flexibility for half of the world where the start of the week is not monday.

@simon-zumbrunnen
Copy link
Author

@boc-the-git It is also uncommon to need to look at what meetings you had yesterday. But still every calendar app shows you the whole week. But yes, usually you have the option to see a single day, a week or a month. But yes, an option to choose whether to start at today or at the start of the week could make sense? Would this option make sense as a global setting or in this calendar dropdown?

@DenuxPlays This would already be possible by setting the start of the week to thursday. I don't know what other consequences this would bring though.

@simon-zumbrunnen
Copy link
Author

@Kuchenpirat Somehow your comment was not yet there when I wrote my text. There is already the option to configure what day is the start of the week. In my code I already take this into account (household.value?.preferences?.firstDayOfWeek).

@Kuchenpirat
Copy link
Collaborator

Ah, yeah, I forgot about that option.
Then it would be just a toggle to enable start with the first day of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants