feat: Add ability to filter by nutritional values for meal plan rules #4859
+56
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parumpum
changed the title
michael-genson
requested changes
Jan 19, 2025
| @@ -148,6 +148,27 @@ export default defineComponent({ | |||
| label: i18n.tc("general.date-updated"), | |||
| type: "date", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
These have to be snake_case otherwise they end up being invalid on the frontend
nutrition.carbohydrate_content, etc.
When I try adding this to my meal plan rules, and I go to edit the rule again, it gets removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
Adds the ability to set meal plan queries for Calories, Protein, Fat, and Carbohydrates.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2712
Testing
Manually tested some queries with recipes that matched and didn't match the nutritional criteria. Added unit test cases.