-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add additional information and tips to Backup & Restore Usage Documentation Page & Shopping List #4843
base: mealie-next
Are you sure you want to change the base?
Conversation
- Adding notes regarding the Settings > Backup page in addition to the URL - Listed out some additional actions that can be performed in this page. Added a tip for manual review / adjustment of the database.json file in the event that a restore fails - Changed some verbiage (removing pluralization on some items)
Thanks for taking the time to raise a PR @ChipSkylark37! Whilst I haven't gone through the actual doco change in detail, there's 2 key things to address with the PR itself.
|
- Adding notes regarding how to access via the Settings > Backup page in addition to the URL slug. - Location of 'backup button' changed from bottom left to top left - Listed out some additional actions that can be performed in this page. - Added a tip for manual review / adjustment of the database.json file in the event that a restore fails - Changed some verbiage (removing pluralization on some items)
I believe I have corrected the errors and performed a new commit after syncing the latest nightly. |
…med, tips, and some examples. - Added location of Shopping Lists from Sidebar. - Added some common things that can be done (See added items, see linked recipes, checking off an item, sorting items, creating / sorting labels. - Added tip for unchecking a checked of item - Added tip for using 'Food' / 'Smart Handling' to combine ingredients - Added tip for using Labels to sort (however you may want)
Additionally I made some changes to the Shopping List Section. Would it be recommended to start a new commit for each one of these? I'm still learning the system a bit so I could use some advice on that. |
Hey all - I was just recently moving my instance from SQL > Postgres and was going to update the documentation a bit more. I synced the latest mealie:nightly to my own fork, which overwrote the documentation changes in my local fork. If this PR gets merged, I can then resync and do some further updates. Is there anything I need to do to help get these changes merged? |
Depends if you mean commit or pull request. As for a pull request, the general rule is that the smaller the better, as it allows for it to be reviewed more easily. Again for docs though, it's a grey area. |
They'd still exist on the branch they belong to - you can see them on here: https://github.com/ChipSkylark37/mealie/tree/patch-1 |
I agree with the changes to make this read better. Co-authored-by: boc-the-git <[email protected]>
Accepted suggestion for how 'Unchecking' an item is handled. Co-authored-by: boc-the-git <[email protected]>
- Changed language as per suggestions: mealie-recipes#4843 - Moved around some of the tips that were added - Added a note on using a 'Want to Make' tag under Cookbooks as per a discord conversation with Michael (great tip!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and make changes per conversations.
Forgive me as I don't want to spam, but I believe I've made all requested changes. Since I'm still new to this, I can't tell if there's any action needed on my part or if this is all the normal checks / waiting for someone else to review & approve. Cheers! |
If you have addressed the feedback above you should be all good to go. |
- Removed Images until I can determine the best way to upload them (or use the SVG files) - Fixed the 'four spaces' instead of using a Tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed suggested changes:
- (Hopefully) fixed the indentation. I used a 'Tab' instead of 'Four Spaces'
- Removed images / assets temporarily while I think about the best way to do this moving forward since I like the idea of images, but dont want to have to upload images each time.
To avoid confusion / manual modifications, removing the note of "Make it Later'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed 'Make Later'
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
None - I am looking through some of the documentation and looking to offer some assistance on pieces that could use clarity or an update.
Special notes for your reviewer:
This is my first PR so I wanted to make some small changes to the documentation and see what the process looks like.