Add short project description #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be picked up by PyPI and others.
Natim
reviewed
Jan 29, 2025
| @@ -5,6 +5,7 @@ build-backend = "hatchling.build" | |||
| [project] | |||
| name = "schwifty" | |||
| dynamic = ["version"] | |||
| description = "IBAN parsing and validation" | |||
There was a problem hiding this comment.
Suggested change
| description = "IBAN parsing and validation" | |
| description = "SWIFT network IBAN parsing and validation" |
There was a problem hiding this comment.
There was a problem hiding this comment.
I copied the description from GitHub. I‘d rather not deviate from that.
If you want that change, better apply it everywhere?
Also, SWIFT is only mentioned in an aside about the name, can‘t find it elsewhere with a quick glace. Doesn‘t seem to be that important then?
There was a problem hiding this comment.
I'm also okay with the description without specifically mentioning SWIFT
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 22 22
Lines 1218 1218
Branches 95 95
=======================================
Hits 1125 1125
Misses 75 75
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be picked up by PyPI and others.
Currently, schwifty appears in PyPI search results with a description of "None".