Skip to content

Add Japanese translations in SVGRef.ejs #12881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Japanese translations in SVGRef.ejs #12881

wants to merge 1 commit into from

Conversation

mfuji09
Copy link
Contributor

@mfuji09 mfuji09 commented Apr 6, 2025

Summary

Add Japanese translations in SVGRef.ejs
Fixes #12880

Problem

Solution

Screenshots

Before

After

How did you test this change?

@mfuji09 mfuji09 requested a review from a team as a code owner April 6, 2025 12:05
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Apr 6, 2025
caugner
caugner reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kumascript macros in yari are deprecated and no longer used, please open a PR against the SVGRef sidebar definition in mdn/content instead:

https://github.com/mdn/content/blob/fac054dcb3d82ac534f8bae21755f15ef2e644f7/files/sidebars/svgref.yaml#L71-L74

🙏

@caugner caugner closed this Apr 7, 2025
@caugner caugner mentioned this pull request Apr 14, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner left review comments

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some words in the SVG sidebar aren't translated in Japanese.
2 participants
@mfuji09 @caugner