chore(macros/WebExtAllCompatTables): replace {{Compat}} call #10215
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
fiji-flo
requested changes
Feb 12, 2024
There was a problem hiding this comment.
@teoli2003 this is a tough choice. Either we duplicate or we keep the internal usage.
I'm fine with duplicating, but I would ask to mention this in Compat.ejs so we change it in both places (if we ever change it).
|
@teoli2003 Please take a look at Florian's comment above, when you have a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We deprecated the parameter of
{{Compat}}years ago.To actually remove it and simplify the codebase, we need to get rid of its only call (with a parameter) from yari.
Problem
We cannot remove the (almost dead) code in
{{Compat}}Solution
Hardcode (two lines) the generation of the HTML directly into
{{WebExtAllCompatTables}}.Screenshots
No Change (Verified locally)
How did you test this change?
Tested locally.