Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

use new @mdn/browser-compat-data #1427

Merged
merged 1 commit into from
Oct 7, 2020
Merged

use new @mdn/browser-compat-data #1427

merged 1 commit into from
Oct 7, 2020

Conversation

escattone
Copy link
Contributor

Fixes #1425

Per mdn/browser-compat-data#6640, stop using deprecated mdn-browser-compat-data npm package and use the new @mdn/browser-compat-data package instead.

@escattone escattone requested a review from peterbe October 7, 2020 20:25
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how to test this.
I did cd kumascript && git remote escattone ... && git checkout escattone/use-new.. && cd .. and then a full docker-compose pull.
But before I started, just make sure it's using these files and something from the image, I put in a console.log(...) in the kumascript/macros/Compat.ejs but it never prints anywhere in docker-compose up.
So I can't tell if it's using the local ./kumascript/ or if it's using the DockerHub image. Sigh.

But each individual line of change looks correct and very sane.
I guess we get a chance to try this again before we make a prod release. Just to be safe.

@escattone
Copy link
Contributor Author

@peterbe Just FYI, I built and ran (via docker-compose) this kumascript image locally, double-checked that I could require("@mdn/browser-compat-data"), and then re-rendered a page with the compat macro. All of it was successful.

@escattone escattone merged commit 7c6ef67 into mdn:master Oct 7, 2020
@escattone escattone deleted the use-new-mdn-browser-compat-data-1425 branch October 7, 2020 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use @mdn/browser-compat-data rather than deprecated mdn-browser-compat-data
2 participants