Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Update syntax for [-webkit]-mask-{clip,origin} #839

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 19, 2024

Description

the syntax for mask-cli and mask-origin has update to using <coord-box> type

the spec change happens in w3c/fxtf-drafts@1c75a54, as the margin-box value is not intended to be supported

-webkit-mask-clip also support the new view-box,stroke-box,fill-box value
-webkit-mask-origin also support the new view-box,stroke-box,fill-box value

Motivation

Additional details

https://developer.mozilla.org/en-US/docs/Web/CSS/mask-origin
https://drafts.fxtf.org/css-masking/#the-mask-origin

Related issues and pull requests

css/properties.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 19, 2024 08:27
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 19, 2024 08:27
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team December 19, 2024 08:27
@skyclouds2001 skyclouds2001 changed the title feat(css): Update syntax for [-webkit]-mask-origin feat(css): Update syntax for [-webkit]-mask-{clip,origin} Dec 19, 2024
css/properties.json Outdated Show resolved Hide resolved
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit c73adfe into mdn:main Dec 21, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the mask-origin branch December 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants