Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): add missing css functions #829

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

his PR add css functions that are in syntaxes.json but not in functions.json to functions.json, which seems to be the current behavior

see also #811

note data is not check with spec but just simply copy from syntaxes.json

this PR is te follow up of #827, and this only cares about css math functions

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 14, 2024 13:03
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 14, 2024 13:03
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team December 14, 2024 13:03
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you :)

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you :)

@pepelsbey pepelsbey merged commit 9fe3138 into mdn:main Dec 17, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the css-function-2 branch December 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants