Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): Add missing <position-area> syntax for position-area property #793

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feat(css): Add missing <position-area> syntax for position-area property #793

merged 3 commits into from
Nov 27, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 22, 2024 •
edited
Loading

@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 22, 2024 15:15
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 22, 2024 15:15
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team November 22, 2024 15:15
bsmth
bsmth reviewed Nov 22, 2024
View reviewed changes
css/syntaxes.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 requested a review from bsmth November 24, 2024 17:07
bsmth
bsmth approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@bsmth bsmth merged commit 3722a02 into mdn:main Nov 27, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
@skyclouds2001 skyclouds2001 deleted the position-area branch November 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @bsmth