Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Add missing <anchor-name> syntax for position-anchor property #792

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 22, 2024

Description

Motivation

Additional details

https://drafts.csswg.org/css-anchor-position-1/#position-anchor
https://drafts.csswg.org/css-anchor-position-1/#typedef-anchor-name

Related issues and pull requests

reported in #597

@skyclouds2001 skyclouds2001 changed the title add missing <anchor-name> syntax definition for position-anchor property feat(css): Add missing <anchor-name> syntax definition for position-anchor property Nov 22, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 22, 2024 15:10
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 22, 2024 15:10
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team November 22, 2024 15:10
@skyclouds2001 skyclouds2001 changed the title feat(css): Add missing <anchor-name> syntax definition for position-anchor property feat(css): Add missing <anchor-name> syntax for position-anchor property Nov 22, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍🏻

@bsmth bsmth merged commit 350f183 into mdn:main Nov 22, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the position-anchor branch November 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants