Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Update syntax for at_font-palette-values/override-colors #780

Merged

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 17, 2024

Description

spec at https://drafts.csswg.org/css-fonts/#override-color, the syntax change happens in w3c/csswg-drafts@f608f7d, see also w3c/csswg-drafts#9555 and w3c/csswg-drafts#7010

Motivation

Additional details

Related issues and pull requests

reported in #597

/cc @lahmatiy

@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 17, 2024 20:51
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 17, 2024 20:51
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team November 17, 2024 20:51
@bsmth bsmth changed the title Update syntax for @font-palette-values/override-colors feat(css): Update syntax for @font-palette-values/override-colors Nov 18, 2024
css/at-rules.json Outdated Show resolved Hide resolved
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a +1, thank you!

@bsmth bsmth changed the title feat(css): Update syntax for @font-palette-values/override-colors feat(css): Update syntax for at_font-palette-values/override-colors Nov 27, 2024
@pepelsbey pepelsbey merged commit 6f8e474 into mdn:main Dec 2, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the @font-palette-values/override-colors branch December 2, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants