Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CSS zoom should be a not animatable property #748

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

yomotsu
Copy link
Contributor

@yomotsu yomotsu commented Jul 22, 2024

Description

Fix the animatable type of CSS zoom to be not-animatable.

Motivation

According to the WD of the CSS zoom property, the animation type of the zoom property is not animatable.
Some browsers, such as Firefox, which recently started supporting zoom, treat it as animatable though.

Here is a capture of the WD page.
image

Additional details

Related issues and pull requests

Copy link
Contributor

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 23, 2024
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you :)

Browsers are all over the place with the zoom animation, but the data should be aligned with the spec.

I filed a bug for Firefox, let’s see how it goes.

@pepelsbey pepelsbey merged commit 3183e91 into mdn:main Sep 9, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@yomotsu yomotsu deleted the patch-1 branch September 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants