Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update scale property syntax to add percentage #746

Closed
wants to merge 0 commits into from

Conversation

JayaKrishnaNamburu
Copy link
Contributor

@JayaKrishnaNamburu JayaKrishnaNamburu commented Jul 5, 2024

Description

The scale individual transform property accepts number as well as percentage as a property value. Updating the syntax here.

Motivation

I was using csstree which is consuming mdn-data as a source to validate. When i was trying to use it's lexer to match the property value for scale. It is throwing error for percentage values. Then started looking around and found the syntax in the mdn-data needs an update.

Additional details

W3 - https://www.w3.org/TR/css-transforms-2/#propdef-scale
MDN - https://developer.mozilla.org/en-US/docs/Web/CSS/scale#values
mdn/content#18269

I have create a repro to quickly check the bug using csstree here.
https://codesandbox.io/p/github/JayaKrishnaNamburu/css-tree-scale-property-bug/main?file=%2Fmain.js%3A12%2C1&import=true&workspaceId=df6c21a4-866b-4200-a851-bfd2875969d8

Copy link
Contributor

github-actions bot commented Jul 5, 2024

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant