Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l10n/css): replace removed macros #745

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix(l10n/css): replace removed macros #745

merged 1 commit into from
Jul 3, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Jul 2, 2024

Description

Update removed macros. These macros don't exist anymore and only work because of a workaround.

xref_csslength -> cssxref("length")
xref_cssangle -> cssxref("angle")

Motivation

As much as we wanted to not use mdn/data in rari we need to. At least we try to remove some hacks so let's update these macros.

xref_csslength -> cssxref("length")
xref_cssangle -> cssxref("angle")
Copy link
Contributor

github-actions bot commented Jul 2, 2024

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@caugner caugner changed the title chore(l10): update macros fix(l10n): replace removed macros Jul 3, 2024
@caugner caugner changed the title fix(l10n): replace removed macros fix(l10n/css): replace removed macros Jul 3, 2024
@caugner caugner merged commit b9dcf29 into main Jul 3, 2024
4 checks passed
@caugner caugner deleted the update-macros branch July 3, 2024 09:21
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants