Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Add text keyword to background-clip #744

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TrySound
Copy link

@TrySound TrySound commented Jun 28, 2024

Description

Added text keyword to background-clip value.

Motivation

All browsers already support unprefixed background-clip with text keyword.

Additional details

Related issues and pull requests

See mdn#201 and https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip

All browsers already support unprefixed version and text keyword.
Copy link
Contributor

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 2, 2024
@bsmth
Copy link
Member

bsmth commented Sep 17, 2024

Thanks for the additions. The page https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip#specifications is currently targeting spec version "Module Level 3", and the syntax for background-clip: text may change, there are open discussions about it: https://drafts.csswg.org/css-backgrounds-4/#propdef-background-clip.

We may want to wait until the open questions on this spec are resolved. The linked PR (#201) has a discussion about this already.

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Sep 20, 2024
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Oct 25, 2024
@bsmth bsmth requested a review from a team as a code owner November 5, 2024 15:12
@bsmth bsmth requested review from bsmth and removed request for a team November 5, 2024 15:12
@TrySound
Copy link
Author

TrySound commented Nov 5, 2024

Wow, nice!

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Nov 8, 2024
@bsmth bsmth changed the title Add text keyword to background-clip feat(css): Add text keyword to background-clip Nov 18, 2024
@@ -2241,7 +2241,7 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/background-blend-mode"
},
"background-clip": {
"syntax": "<box>#",
"syntax": "[ <box> | text ]#",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"syntax": "[ <box> | text ]#",
"syntax": "<bg-clip>#",

then add a bg-clip syntax entry in syntaxes.json

the visual-box syntax entry is already added, so there is no use to adjust it

@skyclouds2001
Copy link
Contributor

also per bcd, border-area value is supported in safari preview browser, this can be added at the same time

see:
https://bugs.webkit.org/show_bug.cgi?id=277693
https://bugs.webkit.org/show_bug.cgi?id=277842
https://bugs.webkit.org/show_bug.cgi?id=277910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants