-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): Add text keyword to background-clip #744
base: main
Are you sure you want to change the base?
Conversation
See mdn#201 and https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip All browsers already support unprefixed version and text keyword.
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
Thanks for the additions. The page https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip#specifications is currently targeting spec version "Module Level 3", and the syntax for We may want to wait until the open questions on this spec are resolved. The linked PR (#201) has a discussion about this already. |
Wow, nice! |
@@ -2241,7 +2241,7 @@ | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/background-blend-mode" | |||
}, | |||
"background-clip": { | |||
"syntax": "<box>#", | |||
"syntax": "[ <box> | text ]#", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"syntax": "[ <box> | text ]#", | |
"syntax": "<bg-clip>#", |
then add a bg-clip
syntax entry in syntaxes.json
the visual-box
syntax entry is already added, so there is no use to adjust it
also per bcd, see: |
Description
Added
text
keyword tobackground-clip
value.Motivation
All browsers already support unprefixed background-clip with text keyword.
Additional details
Related issues and pull requests
text
andborder
keywords to background-clip #201