-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update zh-CN
to i10n patch 1
#734
Conversation
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
Thanks for the PR! Is there a description available somewhere so we know the scope of the changes? (will there be a patch 2 or follow-up PRs?) |
yes, Subsequent possible submission of patch 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me when I used machine translation, are you able to get a zh-CN reviewer to have a look, also? Thank you!
OK /cc @yin1999 ,this is zh-CN reviewer |
Hey @T34-active. Thanks for the translation. Actually, I've finished some translation in my fork (see: yin1999#1). I've reviewed some translation you added in this PR, and felt that some of the translations could be improved by yourself first. For example, unnecessary quantifier translations (e.g. Please do it by yourself first, and ping me again after you think it's ready for review by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix content
/cc @yin1999 I fix a few content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @jasonren0403
Co-authored-by: A1lo <[email protected]>
Co-authored-by: A1lo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the zh-CN
translation
Search the references of those keys within this repo, or search the English text using Google, or bing, like this: |
Thanks a lot! Merging shortly 🚢 |
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Description
Motivation
Additional details
Related issues and pull requests