fix: descriptions of discrete animation behavior between visible and hidden #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
idle
teoli2003
pushed a commit
that referenced
this pull request
Dec 28, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.2](v2.3.1...v2.3.2) (2023-12-28) ### Bug Fixes * descriptions of discrete animation behavior between visible and hidden ([#690](#690)) ([eb3bd6b](eb3bd6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #688, part of the work was to add descriptions of the new specific animation behavior of certain "discrete" animated properties —
display,content-visibility, andoverlay— when animating from a hidden state or a visible state. However, on talking to some Chrome engineering folks about this, I realized that some of my descriptions were not quite right.This PR aims to fix those descriptions.
The description I was sent by the Chrome engineering folk is as follows:
"The idea behind "p = 1" is that during transitions between certain values for certain properties which we consider invisible to visible or vice versa, the browser will automatically choose the "visible" option for the duration of the animation it creates.
For example, if you transition from "display:none" to "display:block", the element will be "display:block" for the entire animation created by the transition.
And likewise if you transition from "display:block" to "display:none", the element will be "display:block" for the entire animation created by the transition.
However, if you transition from "display:flex" to "display:block", the element's display value will switch halfway through the animation.
This behavior is applied to content-visibility:hidden, display:none, visibility:hidden, and overlay:none."
Motivation
Additional details
Related issues and pull requests