-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): update "outline-style" syntax #574
base: main
Are you sure you want to change the base?
Conversation
Formal Syntax incorrectly implies that all border-style values can be used. Resolving issue: mdn#567 See for more info: https://www.w3.org/TR/css-ui-4/#typedef-outline-line-style
@@ -6948,7 +6948,7 @@ | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/outline-offset" | |||
}, | |||
"outline-style": { | |||
"syntax": "auto | <'border-style'>", | |||
"syntax": "auto | <'outline-line-style'>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to have outline-line-style defined somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @teoli2003 - for getting this resolved, I'm not finding any MDN URL specified for this. I'm going to head over to the mdn/content repo and submit a PR for this.
Is this what we had in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or was it something along the lines of a similiar example, outline-width
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should list the valid values and not use <'outline-line-style'>". It seems not useful to create a whole type page for something used in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timeowilliams Do you still want to add the values?
Basically (source):
<outline-line-style> accepts the same values as <line-style> (CSS Backgrounds 3 §3.2 Line Patterns: the border-style properties) with the same meaning, except that hidden is not a legal outline style. In addition, the outline-style property accepts the value auto.
And line-style
accepts these values (source):
<line-style> = none | hidden | dotted | dashed | solid | double | groove | ridge | inset | outset
Formal Syntax incorrectly implies that all border-style values can be used. Fix #567
See for more info: https://www.w3.org/TR/css-ui-4/#typedef-outline-line-style