Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(css): update mask-repeat and mask-position according to spec #494

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sigveio
Copy link
Contributor

@sigveio sigveio commented Jul 25, 2021

This pull request aims to update the initial value of mask-repeat and mask-position to be in line with the current spec.

Specs:
https://drafts.fxtf.org/css-masking/#the-mask-repeat
https://drafts.fxtf.org/css-masking/#the-mask-position

Additional context:
w3c/csswg-drafts/issues/599
w3c/fxtf-drafts/issues/111

@sigveio sigveio changed the title fix(css): update mask-repeat according to spec fix(css): update "mask-repeat" and "mask-position" according to spec Jul 25, 2021
@sigveio sigveio marked this pull request as draft July 28, 2021 12:58
@sigveio sigveio changed the title fix(css): update "mask-repeat" and "mask-position" according to spec [WIP] fix(css): update mask-repeat and mask-position according to spec Jul 28, 2021
@sigveio
Copy link
Contributor Author

sigveio commented Jul 28, 2021

Going over the spec for this again, I noticed that some of the other JSON properties for these two could also use updating. So I'm marking it as a WIP for now.

This is the definition of appliesto in the latest spec for these elements:

All elements. In SVG, it applies to container elements excluding the defs element, all graphics elements and the use element

Which deviates from the allElementsSVGContainerElements used in the JSON currently.

What would be a suitable replacement?

Attempting to break it down:

All elements. -> allElements
In SVG, it applies to container elements -> SVGContainerElements
excluding the defs element, all graphics elements and the use element -> ExcludingDefsGraphicsAndUse

Result:

allElementsSVGContainerElementsExcludingDefsGraphicsAndUse

or (perhaps slightly clearer)

allElementsAndSVGContainerElementsExcludingDefsGraphicsAndUse

Thoughts?

Excluding (more in line with text in spec) or Except (more in line with existing schema entries)?

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 4, 2023
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Mar 29, 2024
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label May 10, 2024
@@ -6381,7 +6381,7 @@
"groups": [
"CSS Masking"
],
"initial": "center",
"initial": "0% 0%",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already landing in 2987ea9

@@ -6397,7 +6397,7 @@
"groups": [
"CSS Masking"
],
"initial": "no-repeat",
"initial": "repeat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already landing in b36469e

@skyclouds2001
Copy link
Contributor

Going over the spec for this again, I noticed that some of the other JSON properties for these two could also use updating. So I'm marking it as a WIP for now.

This is the definition of appliesto in the latest spec for these elements:

All elements. In SVG, it applies to container elements excluding the defs element, all graphics elements and the use element

Which deviates from the allElementsSVGContainerElements used in the JSON currently.

What would be a suitable replacement?

Attempting to break it down:

All elements. -> allElements In SVG, it applies to container elements -> SVGContainerElements excluding the defs element, all graphics elements and the use element -> ExcludingDefsGraphicsAndUse

Result:

allElementsSVGContainerElementsExcludingDefsGraphicsAndUse

or (perhaps slightly clearer)

allElementsAndSVGContainerElementsExcludingDefsGraphicsAndUse

Thoughts?

Excluding (more in line with text in spec) or Except (more in line with existing schema entries)?

Personnally, both is ok, as this does not affect user

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants