-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix(css): update mask-repeat
and mask-position
according to spec
#494
base: main
Are you sure you want to change the base?
Conversation
mask-repeat
and mask-position
according to spec
Going over the spec for this again, I noticed that some of the other JSON properties for these two could also use updating. So I'm marking it as a WIP for now. This is the definition of
Which deviates from the What would be a suitable replacement? Attempting to break it down:
Result:
or (perhaps slightly clearer)
Thoughts?
|
@@ -6381,7 +6381,7 @@ | |||
"groups": [ | |||
"CSS Masking" | |||
], | |||
"initial": "center", | |||
"initial": "0% 0%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already landing in 2987ea9
@@ -6397,7 +6397,7 @@ | |||
"groups": [ | |||
"CSS Masking" | |||
], | |||
"initial": "no-repeat", | |||
"initial": "repeat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already landing in b36469e
Personnally, both is ok, as this does not affect user |
This pull request aims to update the initial value of
mask-repeat
andmask-position
to be in line with the current spec.Specs:
https://drafts.fxtf.org/css-masking/#the-mask-repeat
https://drafts.fxtf.org/css-masking/#the-mask-position
Additional context:
w3c/csswg-drafts/issues/599
w3c/fxtf-drafts/issues/111