Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding inheritance data for Sensor API #299

Closed
wants to merge 2 commits into from
Closed

adding inheritance data for Sensor API #299

wants to merge 2 commits into from

Conversation

chrisdavidmills
Copy link
Contributor

As per #295

@chrisdavidmills chrisdavidmills requested a review from ddbeck October 1, 2018 06:00
@Elchi3
Copy link
Member

Elchi3 commented Oct 1, 2018

fyi, it is nice that you update this data here, but MDN macros actually use https://github.com/mdn/kumascript/blob/master/macros/InterfaceData.json. It's messy.

@chrisdavidmills chrisdavidmills mentioned this pull request Oct 1, 2018
Closed
@chrisdavidmills
Copy link
Contributor Author

@Elchi3 I have opened a new PR to put this data in the right place: mdn/kumascript#907

Not sure if we want to add these in both places, or I can just close the old PRs now?

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Oct 2, 2018 •
edited
Loading

Not sure if we want to add these in both places, or I can just close the old PRs now?

The plan is to move all data json files to mdn/data, so this should be kept open and merged too.

@ddbeck ddbeck removed their request for review March 4, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdavidmills @Elchi3 @ExE-Boss