Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-weight syntax for CSS Fonts 4 #234

Merged
merged 2 commits into from
May 30, 2018
Merged

Update font-weight syntax for CSS Fonts 4 #234

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebe859
Update font-weight syntax for CSS Fonts 4
May 24, 2018
1e74853
Simplify syntax
May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4305,7 +4305,7 @@
"status": "standard"
},
"font-weight": {
"syntax": "normal | bold | bolder | lighter | 100 | 200 | 300 | 400 | 500 | 600 | 700 | 800 | 900",
"syntax": "<font-weight-absolute> | bolder | lighter",
"media": "visual",
"inherited": true,
"animationType": "fontWeight",
Expand Down
3 changes: 3 additions & 0 deletions css/syntaxes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@
"font-variant-css21": {
"syntax": "[ normal | small-caps ]"
},
"font-weight-absolute": {
"syntax": "[normal | bold | <number>]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't syntaxes already grouped or have I misunderstood something? I mean it doesn't have any multiplier or anything like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right. I just copied it from the spec, but it looks like this is an instance of what @lahmatiy was talking about in #230.

},
"frames-timing-function": {
"syntax": "frames(<integer>)"
},
Expand Down