feat(css): Add appliesto definition for display:contents #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for the suggestion. Do you have any references to that change and examples of how it might be used or what use cases it improves? @skyclouds2001 could you please have a look? Thank you. |
github-actions
bot
added
the
idle
github-actions
bot
removed
the
idle
| "allElementsExceptTableRowColumnGroupsTableRowsColumns", | ||
| "allElementsExceptTableRowGroupsRowsColumnGroupsAndColumns", | ||
| "allElementsNoEffectIfDisplayNone", | ||
| "allElementsNoEffectIfDisplayNoneOrContents", |
Contributor
There was a problem hiding this comment.
I didn't find any reference about this key, so why add it?
pepelsbey
added
needs info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new key, "allElementsNoEffectIfDisplayNoneOrContents", to the properties.schema.json to more accurately describe the applicability of certain CSS properties.
The existing key "allElementsNoEffectIfDisplayNone" is insufficient for properties like float, which also have no effect on elements with display: contents.
This change allows for more precise documentation by providing a key that covers both none and contents.
Motivation
Additional details
This is achieved in three steps:
Related issues and pull requests