Skip to content

Commit

Permalink
fix(css): Remove ::first-line from margin* props (#706)
Browse files Browse the repository at this point in the history
<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

Correct the `alsoAppliesTo` for the CSS `margin` and
`margin-{top,bottom,left,right.trim}` properties.

### Motivation

The data claims that `margin*` properties apply to the `::first-line`
pseudoelement, which is untrue. They apply to `::first-letter`, but not
`::first-line`. As reported by @Akindin in mdn/content#31806.

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

Fixes mdn/content#31806
  • Loading branch information
ferdnyc authored Jan 20, 2024
1 parent 4f43ef9 commit 8858ac6
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions css/properties.json
Original file line number Diff line number Diff line change
Expand Up @@ -6384,8 +6384,7 @@
],
"order": "uniqueOrder",
"alsoAppliesTo": [
"::first-letter",
"::first-line"
"::first-letter"
],
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin"
Expand Down Expand Up @@ -6458,8 +6457,7 @@
"computed": "percentageAsSpecifiedOrAbsoluteLength",
"order": "uniqueOrder",
"alsoAppliesTo": [
"::first-letter",
"::first-line"
"::first-letter"
],
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-bottom"
Expand Down Expand Up @@ -6532,8 +6530,7 @@
"computed": "percentageAsSpecifiedOrAbsoluteLength",
"order": "uniqueOrder",
"alsoAppliesTo": [
"::first-letter",
"::first-line"
"::first-letter"
],
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-left"
Expand All @@ -6552,8 +6549,7 @@
"computed": "percentageAsSpecifiedOrAbsoluteLength",
"order": "uniqueOrder",
"alsoAppliesTo": [
"::first-letter",
"::first-line"
"::first-letter"
],
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-right"
Expand All @@ -6572,8 +6568,7 @@
"computed": "percentageAsSpecifiedOrAbsoluteLength",
"order": "uniqueOrder",
"alsoAppliesTo": [
"::first-letter",
"::first-line"
"::first-letter"
],
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-top"
Expand All @@ -6592,8 +6587,7 @@
"computed": "asSpecified",
"order": "perGrammar",
"alsoAppliesTo": [
"::first-letter",
"::first-line"
"::first-letter"
],
"status": "experimental",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-trim"
Expand Down

0 comments on commit 8858ac6

Please sign in to comment.